[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: Show hidden dock widgets when activated by a
From:       Thomas =?iso-8859-15?q?L=FCbking?= <thomas.luebking () web ! de>
Date:       2010-10-07 22:11:37
Message-ID: 201010080011.37544.thomas.luebking () web ! de
[Download RAW message or body]

Since git.reviewboard won't accept my svn.reviewboard login (?!?)

Have a look at QMainWindow::tabifiedDockWidgets (hint, if the list is empty, 
your dock of interest is likely not tabified ;-)

Also do not dig for the docks by the object name, that's mega wonky and will 
break sooner or later. Instead either add 3 fuctions 
("setPlaylistAsCurrentTab" etc - "showDock" is quite generic) or add an enum 
and dispatch (map to the widget pointer) it in "setAsCurrentTab( AmarokDockId  
)" (or in worst doubt, dispatch a constant string there)

Cheers,
Thomas

ps: sth. with a qDebug() will likely not be merged ;-)

Am Thursday 07 October 2010 schrieb Daniel Faust:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100030/
> -----------------------------------------------------------
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Since I have tabbed my Navigation and Context views I have to manually
> select the tabs every time I open a bookmark. In my opinion this should be
> done automatically.
> Unfortunately I couldn't come up with a very clean solution. But please
> have a look at the code yourself and share your opinion.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b86470e
>   src/MainWindow.cpp 54c6751
>   src/amarokurls/ContextUrlRunner.cpp 7416fbc
>   src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b
>   src/playlist/PlaylistViewUrlRunner.cpp 749233e
> 
> Diff: http://git.reviewboard.kde.org/r/100030/diff
> 
> 
> Testing
> -------
> 
> I'm running amarok with this patch for many weeks now without any problems.
> 
> 
> Thanks,
> 
> Daniel

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]