'Review Request: Show hidden dock widgets when activated by a bookmark'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Review Request: Show hidden dock widgets when activated by a bookmark
From:       "Daniel Faust" <hessijames () gmail ! com>
Date:       2010-10-07 18:10:13
Message-ID: 20101007181013.26440.56875 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100030/
-----------------------------------------------------------

Review request for Amarok.

Summary
-------

Since I have tabbed my Navigation and Context views I have to manually sele=
ct the tabs every time I open a bookmark.
In my opinion this should be done automatically.
Unfortunately I couldn't come up with a very clean solution. But please hav=
e a look at the code yourself and share your opinion.

Diffs
-----

  src/MainWindow.h b86470e =

  src/MainWindow.cpp 54c6751 =

  src/amarokurls/ContextUrlRunner.cpp 7416fbc =

  src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b =

  src/playlist/PlaylistViewUrlRunner.cpp 749233e =

Diff: http://git.reviewboard.kde.org/r/100030/diff

Testing
-------

I'm running amarok with this patch for many weeks now without any problems.

Thanks,

Daniel

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100030/">http://git.reviewboard.kde.org/r/100030/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since I have tabbed my Navigation and Context views I have to manually \
select the tabs every time I open a bookmark. In my opinion this should be done \
automatically. Unfortunately I couldn&#39;t come up with a very clean solution. But \
please have a look at the code yourself and share your opinion.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m running amarok with this patch for many weeks now without any \
problems.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/MainWindow.h <span style="color: grey">(b86470e)</span></li>

 <li>src/MainWindow.cpp <span style="color: grey">(54c6751)</span></li>

 <li>src/amarokurls/ContextUrlRunner.cpp <span style="color: \
grey">(7416fbc)</span></li>

 <li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: \
grey">(6bb6c0b)</span></li>

 <li>src/playlist/PlaylistViewUrlRunner.cpp <span style="color: \
grey">(749233e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100030/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 