[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: [PATCH] LyricsApplet: optimize changing the title of the applet
From:       Leo Franchi <lfranchi () kde ! org>
Date:       2009-11-19 23:22:20
Message-ID: 43ACFBA7-057C-4D24-B1E3-73AEDD787852 () kde ! org
[Download RAW message or body]

On 19 Nov 2009, at 22:55, Martin wrote:

> Hi,
>
> yesterday I found the following bug: [0]
>
> well...  because I needed something quick to code I decided to fix  
> that bug :)
> after I realized (thanks to Myriam ;)) that it's already been fixed  
> I found
> out that my patch at least optimizes the title changing a bit
>
> the bug itself was already fixed by someone else... but there's  
> still a
> (rare?) corner-case where the title still would not be changed:
> namely when a) a bug in the LyricsEngine b) someone added a new else  
> if (...)
> condition and he forgot to change the title there
>
> now my question: do you think my patch is fine?
> you can see it here:  [1]
>
> if you agree with it I'll open a merge request so it can be merged  
> into
> mainline ;)


Just open a merge request, if it's not fine, we can handle comments  
there. This keeps the related discussion in one place and makes it  
easier to deal with :)

leo

---
Leo Franchi				(512) 775 5637
Tufts University 2010

lfranchi@kde.org
leonardo.franchi@tufts.edu

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]