[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    [PATCH] LyricsApplet: optimize changing the title of the applet
From:       Martin <darklight.xdarklight () googlemail ! com>
Date:       2009-11-19 22:55:20
Message-ID: 200911192355.20125.darklight.xdarklight () googlemail ! com
[Download RAW message or body]

Hi,

yesterday I found the following bug: [0]

well...  because I needed something quick to code I decided to fix that bug :)
after I realized (thanks to Myriam ;)) that it's already been fixed I found 
out that my patch at least optimizes the title changing a bit

the bug itself was already fixed by someone else... but there's still a 
(rare?) corner-case where the title still would not be changed:
namely when a) a bug in the LyricsEngine b) someone added a new else if (...) 
condition and he forgot to change the title there

now my question: do you think my patch is fine?
you can see it here:  [1]

if you agree with it I'll open a merge request so it can be merged into 
mainline ;)

Regards,
Martin

[0] https://bugs.kde.org/show_bug.cgi?id=210798
[1] http://bugsfiles.kde.org/attachment.cgi?id=38428
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]