[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Question regarding "Reload Lyrics" button
From:       Valentin Rouet <v.rouet () gmail ! com>
Date:       2009-09-17 12:34:28
Message-ID: 712d1200909170534v4c357208i67717529e22ce49c () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,
I think it could be problematic for the user having newly fetched lyrics
saved automatically over the old ones, a user can easilyhit reload more or
less accidently and lose changes he may have made to the cached lyrics.
I think it would be better just to split the "edit/save" button in 2
different ones, which would enable one to overwrite cached lyrics with the
fetched ones without having to press "edit", and the former "save" part of
the edit button could be used to stop editing without saving changes (which
can't be done currently).

Valentin

2009/9/16 Martin <darklight.xdarklight@googlemail.com>

> Hi,
>
> I've got a quick question regarding the "reload lyrics" button in the
> lyrics
> applet.
> One of my patches (which just got upstream) enables Amarok to use cached
> lyrics
> This brings one usability change: now when the user presses the "reload
> lyrics" button the lyrics are re-fetched (from the script) BUT they are not
> saved anymore (at least here.. but I'm too tired to investigate that right
> now
> - because if I see that correctly new lyrics SHOULD be saved (correct me
> when
> I'm wrong)).
>
> I've found the following comment in LyricsManager.cpp:
>
> >            //TODO: what is the sane thing to do if we get a valid lyrics
> result but there is cached lyrics set already?
> >            //this entire system needs to be thought through a little
> better
> I think -nhn
>
> that's exactly the question I'm asking myself...
> if you guys tell me what the desired behavior is I'll implement that :)
>
> Regards,
> Martin
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel@kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>

[Attachment #5 (text/html)]

Hi,<br>I think it could be problematic for the user having newly fetched lyrics saved \
automatically over the old ones, a user can easilyhit reload more or less accidently \
and lose changes he may have made to the cached lyrics.<br> I think it would be \
better just to split the &quot;edit/save&quot; button in 2 different ones, which \
would enable one to overwrite cached lyrics with the fetched ones without having to \
press &quot;edit&quot;, and the former &quot;save&quot; part of the edit button could \
be used to stop editing without saving changes (which can&#39;t be done \
currently).<br> <br>Valentin<br><br><div class="gmail_quote">2009/9/16 Martin <span \
dir="ltr">&lt;<a href="mailto:darklight.xdarklight@googlemail.com">darklight.xdarklight@googlemail.com</a>&gt;</span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> Hi,<br>
<br>
I&#39;ve got a quick question regarding the &quot;reload lyrics&quot; button in the \
lyrics<br> applet.<br>
One of my patches (which just got upstream) enables Amarok to use cached<br>
lyrics<br>
This brings one usability change: now when the user presses the &quot;reload<br>
lyrics&quot; button the lyrics are re-fetched (from the script) BUT they are not<br>
saved anymore (at least here.. but I&#39;m too tired to investigate that right \
                now<br>
- because if I see that correctly new lyrics SHOULD be saved (correct me when<br>
I&#39;m wrong)).<br>
<br>
I&#39;ve found the following comment in LyricsManager.cpp:<br>
<br>
&gt;            //TODO: what is the sane thing to do if we get a valid lyrics<br>
result but there is cached lyrics set already?<br>
&gt;            //this entire system needs to be thought through a little better<br>
I think -nhn<br>
<br>
that&#39;s exactly the question I&#39;m asking myself...<br>
if you guys tell me what the desired behavior is I&#39;ll implement that :)<br>
<br>
Regards,<br>
<font color="#888888">Martin<br>
_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br> \
</font></blockquote></div><br>



_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]