[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: [PATCH] fix invalid Q_UNUSED
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2009-09-14 19:21:40
Message-ID: 200909142021.51911.kde () randomguy3 ! me ! uk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


I just committed this, since it was trivial, but a much better way to request 
things to be applied is to do a merge request through gitorious.  That way, 
you automatically get the credit, and, in the long term, it's easier all 
round.

If you could do that for your other patches, that would be useful.

I can't find the page that documents doing merge requests, but this should get 
you started: 
http://techbase.kde.org/Getting_Started/Sources/Amarok_Git_Tutorial#Patch_Contributors

I'll try to make the documentation a bit more useful when someone posts the 
correct information...

Alex


On Monday 14 September 2009 19:37:41 you wrote:
> Hi,
> 
> while doing crazy stuff with amarok's code
> I've found some invalid Q_UNUSED
> actually that parameter IS used (3 lines below)
> 
> here's my patch:
> 
> diff --git a/src/context/applets/videoclip/VideoclipApplet.cpp
> b/src/context/applets/videoclip/VideoclipApplet.cpp
> index 3b30b38..23b1307 100644
> --- a/src/context/applets/videoclip/VideoclipApplet.cpp
> +++ b/src/context/applets/videoclip/VideoclipApplet.cpp
> @@ -277,7 +277,6 @@ VideoclipApplet::constraintsEvent(
> Plasma::Constraints constraints )
>  void
>  VideoclipApplet::paintInterface( QPainter *p, const
> QStyleOptionGraphicsItem *option, const QRect &contentsRect )
>  {
> -    Q_UNUSED( p );
>      Q_UNUSED( option );
>      Q_UNUSED( contentsRect );
>      p->setRenderHint( QPainter::Antialiasing );
> 
> 
> Regards,
> Martin
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel@kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
> 

-- 
Why have I got six monitors?  Because I haven't got room for eight.
  -- Terry Pratchett

["signature.asc" (application/pgp-signature)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]