[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: [PATCH] (needs review) fix lyrics applet
From:       Mark Kretschmann <kretschmann () kde ! org>
Date:       2009-09-14 19:17:27
Message-ID: e93871060909141217r2f8f1e5fv71b9892d176abf15 () mail ! gmail ! com
[Download RAW message or body]

On Mon, Sep 14, 2009 at 9:02 PM, Martin
<darklight.xdarklight@googlemail.com> wrote:
> ok, fixing 'some' lyrics issues was not enough for me :)
> I was really annoyed by the fact that the lyrics applet
> did NOT use system colors. as I'm using the Obisidan Coast
> theme I have a dark color scheme - but somehow (not a bug
> but a feature ;)) the background of the lyrics applet was
> white (SIGH)

Martin, many thanks for your patches. Just one note: You can also
contribute to Amarok by cloning Amarok on Gitorious, and then creating
merge requests for your patches. This makes it easier for us to keep
track of contributions, and allows for commenting and refinement of
the code. Here are some detailed instructions:

http://techbase.kde.org/Getting_Started/Sources/Amarok_Git_Tutorial#Patch_Contributors


But for now the patches are fine too, I've just mentioned this for
possible future contributions :)

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]