[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Dropping IconLoader
From:       "Ian Monroe" <ian () monroe ! nu>
Date:       2008-01-07 17:41:23
Message-ID: f680fec50801070941n5f17a950ub98e698f993818d4 () mail ! gmail ! com
[Download RAW message or body]

On Jan 7, 2008 10:26 AM, Harald Sitter <harald@getamarok.com> wrote:
> Currently we are using IconLoader.cpp to either use our icons or fallback to
> the oxygen ones, which is rather pointless since the new icon spec already
> has a fallback system
>
> media-playback-play-amarok
> falls back to
> media-playback-play
> falls back to
> media-playback
> etc.
>
> So we can completely drop IconLoader (which is kinda no work thanks to
> markey's revert script). Also we should generally use a -amarok suffix for
> all icons, this gives icon themers the possability to include an own set for
> Amarok and we can add actual add icon files as required (e.g. an icon in KDE
> changes so it doesn't fit in with us anymore -> just add an -amarok file to
> our source and the issue is settled).
>
> Also people can remove our -amarok's from binaries if they are compiled with
> latest kde (hence reduce size).
>
> If everyone is ok with it, I'd go for the transition and submit our icon
> requests to Oxygen afterwards.

Couldn't we drop the Amarok icon theme in general? There's still a few
icons missing in Oxygen probably, but they did a pretty good job in
covering all the icons for us (they even have an icon specifically for
"media scripts" so they were obviously paying attention to Amarok).
We'll depend on kdebase/runtime in KDE4 probably, so we should be in
good shape.

Ian
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]