[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 151609] OSD album cover/embedded image bug
From:       Jeff Mitchell <kde-dev () emailgoeshere ! com>
Date:       2007-10-31 21:31:00
Message-ID: 20071031213100.32738.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151609         




------- Additional Comments From kde-dev emailgoeshere com  2007-10-31 22:30 -------
I don't think this patch should go in.

The problem there might be that Qt wasn't compiled with whatever format the album art \
is in.  For instance, it could be a gif but Qt wasn't compiled with gif support.  In \
this case the "bug" would be rather distribution dependent, and you may "solve" it \
simply by recompiling Qt into a new package.  But deleting the album art is \
permanent, and we shouldn't be assuming that the user wants that -- what if they want \
to play that image in iTunes later, from whence it came?

A better solution is the following:  when <wherever covers are used> is determining \
the image to use for the cover, check there to see if there is image data there but \
the image is null according to QImage.  If so, force it to use the "no cover" cover. \
_______________________________________________ Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist


[prev in list] [next in list] [prev in thread] [next in thread]