[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 151609] OSD album cover/embedded image bug
From:       Jeff Kerr <jeff.kerr () gmail ! com>
Date:       2007-10-31 21:37:53
Message-ID: 20071031213753.4900.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151609         




------- Additional Comments From jeff.kerr gmail com  2007-10-31 22:37 -------
Actually, the fix isn't deleting the image out of the Mp3 file, just from
the folder where it extracted it, so it wouldn't affect iTunes.

Also, it was my understanding that album art is stored in another folder as
well - if you clear all files from your tagfolder folder, it still exists
when you run amarok and run the cover manager.

On 31 Oct 2007 21:31:00 -0000, Jeff Mitchell <kde-dev emailgoeshere com>
wrote:
[bugs.kde.org quoted mail]
Actually, the fix isn&#39;t deleting the image out of the Mp3 file, just from the \
folder where it extracted it, so it wouldn&#39;t affect iTunes.<br><br>Also, it was \
my understanding that album art is stored in another folder as well - if you clear \
all files from your tagfolder folder, it still exists when you run amarok and run the \
cover manager. <br><br><div><span class="gmail_quote">On 31 Oct 2007 21:31:00 -0000, \
<b class="gmail_sendername">Jeff Mitchell</b> &lt;<a href="mailto:kde-dev \
emailgoeshere com">kde-dev emailgoeshere com</a>&gt; wrote:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
                0pt 0.8ex; padding-left: 1ex;">
------- You are receiving this mail because: -------<br>You reported the bug, or are \
watching the reporter.<br><br><a \
href="http://bugs.kde.org/show_bug.cgi?id=151609">http://bugs.kde.org/show_bug.cgi?id=151609</a><br><br>
 <br><br><br>------- Additional Comments From kde-dev emailgoeshere \
com&nbsp;&nbsp;2007-10-31 22:30 -------<br>I don&#39;t think this patch should go \
in.<br><br>The problem there might be that Qt wasn&#39;t compiled with whatever \
format the album art is in.&nbsp;&nbsp;For instance, it could be a gif but Qt \
wasn&#39;t compiled with gif support.&nbsp;&nbsp;In this case the &quot;bug&quot; \
would be rather distribution dependent, and you may &quot;solve&quot; it simply by \
recompiling Qt into a new package.&nbsp;&nbsp;But deleting the album art is \
permanent, and we shouldn&#39;t be assuming that the user wants that -- what if they \
want to play that image in iTunes later, from whence it came? <br><br>A better \
solution is the following:&nbsp;&nbsp;when &lt;wherever covers are used&gt; is \
determining the image to use for the cover, check there to see if there is image data \
there but the image is null according to QImage.&nbsp;&nbsp;If so, force it to use \
the &quot;no cover&quot; cover. <br></blockquote></div><br>
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist


[prev in list] [next in list] [prev in thread] [next in thread]