[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 151609] New: OSD album cover/embedded image bug
From:       Jeff Kerr <jeff.kerr () gmail ! com>
Date:       2007-10-31 13:20:07
Message-ID: 20071031142004.151609.jeff.kerr () gmail ! com
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151609         
           Summary: OSD album cover/embedded image bug
           Product: amarok
           Version: 1.4.7
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: amarok-bugs-dist kde org
        ReportedBy: jeff.kerr gmail com


Version:           1.4.7 (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages
OS:                Linux

Certain MP3s with embedded images for cover art show no image in the OSD (not even \
the stock amarok icon).  In my case the songs in question are some of those whose \
album art was set in iTunes (not sure if an old version caused the problem) but it's \
possible that other players/tag editors could reproduce the problem.

A few other notes:
- My ~/.kde/share/apps/amarok/albumcovers/tagcover folder shows numerous files that \
                linux (ubuntu 7.10) doesn't recognize as images in file browser
- The 'bad' embedded image looks fine in iTunes (i have dual-boot to win xp)
- The 'bad' embedded image is set for entire album
- When the tagcover folder is cleared then a 'bad' song is played, the OSD shows the \
                song info with no image.
- After going to iTunes and clearing cover art for a song on the album, coming back, \
clearing tagcover and playing the song, no new file is created in tagcover and the \
proper image is shown (from cover manager I assume).  Then if a 'bad' song from that \
album is played, it shows no cover and the 'bad' image file is created in tagcover. \
If I then play the 'good' song again, no image is shown. (looks like it finds the \
album by hash and chooses the 'bad' image file from tagcover)

After getting the SVN version of amarok, compiling, inserting debug statements, \
re-compiling, etc, I've found a fix for the issue:

In the code where the embedded image is found and saved to the tagcover folder, I \
added a test to create an image using the file.  Then I check if that image variable \
is null and if so, I delete the newly-saved file and return false.  

This seems to fix the problem and should also help for anything amarok seems as an \
embedded image that it can't understand.  I can post the actual code I added (4 \
lines) when I'm back at that computer. \
_______________________________________________ Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist


[prev in list] [next in list] [prev in thread] [next in thread]