[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126918: remove the legacy applets filter
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-01-29 15:00:30
Message-ID: 20160129150030.17778.32672 () mimi ! kde ! org
[Download RAW message or body]
--===============6923460333839691916==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126918/#review91782
-----------------------------------------------------------
Ship it!
Ship it...but lets not do it 2 days before tagging. Wait for the next frameworks \
cycle.
- David Edmundson
On Jan. 28, 2016, 1:24 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126918/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 1:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this list was done because some applets broke with the new shared engine stuff.
>
> since it's many workspace releases ago, unconditionally use the single engine now.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp 48e78cd
> src/plasmaquick/private/appletquickitem_p.h 94cfada
>
> Diff: https://git.reviewboard.kde.org/r/126918/diff/
>
>
> Testing
> -------
>
> every applet in the standard distribution still works correctly (the else branch \
> was never hit anymore)
>
> Thanks,
>
> Marco Martin
>
>
--===============6923460333839691916==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126918/">https://git.reviewboard.kde.org/r/126918/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
it...but lets not do it 2 days before tagging. Wait for the next frameworks \
cycle.</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On January 28th, 2016, 1:24 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2016, 1:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this list was done because some applets broke with the \
new shared engine stuff.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">since it's many workspace releases ago, \
unconditionally use the single engine now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">every applet in the standard distribution still works \
correctly (the else branch was never hit anymore)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(48e78cd)</span></li>
<li>src/plasmaquick/private/appletquickitem_p.h <span style="color: \
grey">(94cfada)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126918/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6923460333839691916==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic