--===============3146973391950701422== Content-Type: multipart/alternative; boundary="===============6923460333839691916==" --===============6923460333839691916== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126918/#review91782 ----------------------------------------------------------- Ship it! Ship it...but lets not do it 2 days before tagging. Wait for the next frameworks cycle. - David Edmundson On Jan. 28, 2016, 1:24 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126918/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 1:24 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this list was done because some applets broke with the new shared engine stuff. > > since it's many workspace releases ago, unconditionally use the single engine now. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp 48e78cd > src/plasmaquick/private/appletquickitem_p.h 94cfada > > Diff: https://git.reviewboard.kde.org/r/126918/diff/ > > > Testing > ------- > > every applet in the standard distribution still works correctly (the else branch was never hit anymore) > > > Thanks, > > Marco Martin > > --===============6923460333839691916== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126918/

Ship it!

Ship it...but lets not do it 2 days before tagging. Wait for the next frameworks cycle.

- David Edmundson

On January 28th, 2016, 1:24 p.m. UTC, Marco Martin wrote:

Review request for Plasma.

By Marco Martin.

Updated Jan. 28, 2016, 1:24 p.m.

Repository: plasma-framework

Description

this list was done because some applets broke with the new shared engine stuff.

since it's many workspace releases ago, unconditionally use the single engine now.

Testing

every applet in the standard distribution still works correctly (the else branch was never hit anymore)

Diffs

src/plasmaquick/appletquickitem.cpp (48e78cd)
src/plasmaquick/private/appletquickitem_p.h (94cfada)

View Diff

--===============6923460333839691916==-- --===============3146973391950701422== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3146973391950701422==--