[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit
From: "Sujith Haridasan" <sujith.h () gmail ! com>
Date: 2014-06-29 15:53:10
Message-ID: 20140629155310.7884.43892 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119015/
-----------------------------------------------------------
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Repository: plasma-mediacenter
Description
-------
This patch fixes the full screen settings of plasma-mediacenter during exit. Though \
its bit hackish which I had done. I would like to make this done better. With this \
change the pmc will save the fullscreen settings before exit.
Diffs
-----
browsingbackends/utility/exit/CMakeLists.txt 48d12a7
browsingbackends/utility/exit/exitbackend.cpp 9fe6cad
shells/newshell/mainwindow.cpp 97655d8
Diff: https://git.reviewboard.kde.org/r/119015/diff/
Testing
-------
Done testing with fullscreen enabled and exit && fullscreen disabled and exit. Both \
results were as expected.
Thanks,
Sujith Haridasan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119015/">https://git.reviewboard.kde.org/r/119015/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes the full screen settings of plasma-mediacenter during \
exit. Though its bit hackish which I had done. I would like to make this done better. \
With this change the pmc will save the fullscreen settings before exit.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done testing with fullscreen enabled and exit && fullscreen \
disabled and exit. Both results were as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/utility/exit/CMakeLists.txt <span style="color: \
grey">(48d12a7)</span></li>
<li>browsingbackends/utility/exit/exitbackend.cpp <span style="color: \
grey">(9fe6cad)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(97655d8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119015/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic