'Re: Review Request 118973: Ensure we mark batteries as connected when the charge is full too'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118973: Ensure we mark batteries as connected when the charge is full too
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-06-29 11:11:44
Message-ID: 20140629111144.7884.49663 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118973/
-----------------------------------------------------------

(Updated June 29, 2014, 11:11 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Solid and Kai Uwe Broulik.

Repository: plasma-workspace

Description
-------

I always found weird that the blue lightning is disabled when my laptop is charged \
and connected, so came up with this little patch.

Diffs
-----

  applets/batterymonitor/contents/ui/BatteryItem.qml 7c93f49 
  lookandfeel/contents/components/InfoPane.qml 5a1bae0 

Diff: https://git.reviewboard.kde.org/r/118973/diff/

Testing
-------

Seems to work.

Thanks,

Aleix Pol Gonzalez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118973/">https://git.reviewboard.kde.org/r/118973/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Solid and Kai Uwe Broulik.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated June 29, 2014, 11:11 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I always found weird that the blue lightning is disabled when my laptop \
is charged and connected, so came up with this little patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems to work.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/batterymonitor/contents/ui/BatteryItem.qml <span style="color: \
grey">(7c93f49)</span></li>

 <li>lookandfeel/contents/components/InfoPane.qml <span style="color: \
grey">(5a1bae0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118973/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 