[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114725: fix the KateSaveModifiedDialog workflow
From: "Commit Hook" <null () kde ! org>
Date: 2013-12-29 16:59:01
Message-ID: 20131229165901.21904.62014 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114725/#review46391
-----------------------------------------------------------
This review has been submitted with commit d274ba365d74c0a03c1feb3a56a4a15f300226e6 \
by Michal Humpula to branch KDE/4.12.
- Commit Hook
On Dec. 29, 2013, 4:58 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114725/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2013, 4:58 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 326224
> http://bugs.kde.org/show_bug.cgi?id=326224
>
>
> Repository: kate
>
>
> Description
> -------
>
> Seems that cleanup #46a12089 messed with the workflow of KateSaveModifiedDialog. \
> See linked bugreport for description.
> The reason for that is, that clicking Yes button will result in calling done(Yes) \
> afterwards so
> - calling done(whatever) in slot yesClicked doesn't make a difference.
> - dialog is accepted everytime
>
> see the code:
> http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/kdialog_8cpp_source.html#l00902
>
> If you "ship it" this review, please don't forget to mention, which versions to \
> ship it to:) (the frameworks version should not suffer the same problem, because of \
> migration from KDialog->QDialog)
>
> Diffs
> -----
>
> kate/app/katesavemodifieddialog.cpp 2648ad9
>
> Diff: https://git.reviewboard.kde.org/r/114725/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114725/">https://git.reviewboard.kde.org/r/114725/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d274ba365d74c0a03c1feb3a56a4a15f300226e6 by Michal Humpula to \
branch KDE/4.12.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On December 29th, 2013, 4:58 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 4:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326224">326224</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems that cleanup #46a12089 messed with the workflow of \
KateSaveModifiedDialog. See linked bugreport for description.
The reason for that is, that clicking Yes button will result in calling done(Yes) \
afterwards so
- calling done(whatever) in slot yesClicked doesn't make a difference.
- dialog is accepted everytime
see the code:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/kdialog_8cpp_source.html#l00902
If you "ship it" this review, please don't forget to mention, which \
versions to ship it to:) (the frameworks version should not suffer the same problem, \
because of migration from KDialog->QDialog)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katesavemodifieddialog.cpp <span style="color: \
grey">(2648ad9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114725/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic