--===============2131175496875067552== Content-Type: multipart/alternative; boundary="===============6583118896914774023==" --===============6583118896914774023== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114725/#review46391 ----------------------------------------------------------- This review has been submitted with commit d274ba365d74c0a03c1feb3a56a4a15f300226e6 by Michal Humpula to branch KDE/4.12. - Commit Hook On Dec. 29, 2013, 4:58 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114725/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2013, 4:58 p.m.) > > > Review request for Kate. > > > Bugs: 326224 > http://bugs.kde.org/show_bug.cgi?id=326224 > > > Repository: kate > > > Description > ------- > > Seems that cleanup #46a12089 messed with the workflow of KateSaveModifiedDialog. See linked bugreport for description. > > The reason for that is, that clicking Yes button will result in calling done(Yes) afterwards so > - calling done(whatever) in slot yesClicked doesn't make a difference. > - dialog is accepted everytime > > see the code: > http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/kdialog_8cpp_source.html#l00902 > > If you "ship it" this review, please don't forget to mention, which versions to ship it to:) (the frameworks version should not suffer the same problem, because of migration from KDialog->QDialog) > > > Diffs > ----- > > kate/app/katesavemodifieddialog.cpp 2648ad9 > > Diff: https://git.reviewboard.kde.org/r/114725/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > > --===============6583118896914774023== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114725/

This review has been submitted with commit d274ba365d74c0a03c1feb3a56a4a15f300226e6 by Michal Humpula to branch KDE/4.12.

- Commit Hook

On December 29th, 2013, 4:58 p.m. UTC, Michal Humpula wrote:

Review request for Kate.

By Michal Humpula.

Updated Dec. 29, 2013, 4:58 p.m.

Bugs: 326224

Repository: kate

Description

Seems that cleanup #46a12089 messed with the workflow of KateSaveModifiedDialog. See linked bugreport for description.

The reason for that is, that clicking Yes button will result in calling done(Yes) afterwards so
- calling done(whatever) in slot yesClicked doesn't make a difference.
- dialog is accepted everytime

see the code:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/kdialog_8cpp_source.html#l00902

If you "ship it" this review, please don't forget to mention, which versions to ship it to:) (the frameworks version should not suffer the same problem, because of migration from KDialog->QDialog)

Diffs

kate/app/katesavemodifieddialog.cpp (2648ad9)

--===============6583118896914774023==-- --===============2131175496875067552== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============2131175496875067552==--