[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Supports KDE3 way of starting man/info-pages
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-11-27 18:35:42
Message-ID: 20101127183542.7847.93159 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5985/#review9008
-----------------------------------------------------------
Ship it!
the logic looks fine, but calling it "kde3Shortcut" is not a great name. it=
implies knowing what kde3 was doing and doesn't actually describe what the=
code is attempting to do at all (man/info lookups). please replace it with=
a descriptive name before committing.
- Aaron
On 2010-11-27 16:57:02, Matthias Fuchs wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5985/
> -----------------------------------------------------------
> =
> (Updated 2010-11-27 16:57:02)
> =
> =
> Review request for Plasma and Teemu Rytilahti.
> =
> =
> Summary
> -------
> =
> Supports KDE3 of starting man-pages (#term) and info-pages (##term).
> This is way faster than typing "man:" or "info:".
> BUG:200556
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationr=
unner.cpp 1200935 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5985/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matthias
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5985/">http://svn.reviewboard.kde.org/r/5985/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the logic looks fine, \
but calling it "kde3Shortcut" is not a great name. it implies knowing what \
kde3 was doing and doesn't actually describe what the code is attempting to do at \
all (man/info lookups). please replace it with a descriptive name before \
committing.</pre> <br />
<p>- Aaron</p>
<br />
<p>On November 27th, 2010, 4:57 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Teemu Rytilahti.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-27 16:57:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Supports KDE3 of starting man-pages (#term) and info-pages (##term). \
This is way faster than typing "man:" or "info:". \
BUG:200556</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp \
<span style="color: grey">(1200935)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5985/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic