From kde-panel-devel Sat Nov 27 18:35:42 2010 From: "Aaron Seigo" Date: Sat, 27 Nov 2010 18:35:42 +0000 To: kde-panel-devel Subject: Re: Review Request: Supports KDE3 way of starting man/info-pages Message-Id: <20101127183542.7847.93159 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129088300223598 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0395549096==" --===============0395549096== Content-Type: multipart/alternative; boundary="===============0604726974473533989==" --===============0604726974473533989== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5985/#review9008 ----------------------------------------------------------- Ship it! the logic looks fine, but calling it "kde3Shortcut" is not a great name. it= implies knowing what kde3 was doing and doesn't actually describe what the= code is attempting to do at all (man/info lookups). please replace it with= a descriptive name before committing. - Aaron On 2010-11-27 16:57:02, Matthias Fuchs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5985/ > ----------------------------------------------------------- > = > (Updated 2010-11-27 16:57:02) > = > = > Review request for Plasma and Teemu Rytilahti. > = > = > Summary > ------- > = > Supports KDE3 of starting man-pages (#term) and info-pages (##term). > This is way faster than typing "man:" or "info:". > BUG:200556 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationr= unner.cpp 1200935 = > = > Diff: http://svn.reviewboard.kde.org/r/5985/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matthias > = > --===============0604726974473533989== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5985/

Ship it!

the logic =
looks fine, but calling it "kde3Shortcut" is not a great name. it=
 implies knowing what kde3 was doing and doesn't actually describe what=
 the code is attempting to do at all (man/info lookups). please replace it =
with a descriptive name before committing.

- Aaron

On November 27th, 2010, 4:57 p.m., Matthias Fuchs wrote:

Review request for Plasma and Teemu Rytilahti.

By Matthias Fuchs.

Updated 2010-11-27 16:57:02

Descripti= on

Supports KDE3 of starting man-pages (#term) and info-pages (=
##term).
This is way faster than typing "man:" or "info:".
BUG:200556

Diffs=

/trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/location= runner.cpp (1200935)

View Diff

--===============0604726974473533989==-- --===============0395549096== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0395549096==--