[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: Make the attribute() and property() methods in
From: "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date: 2010-09-23 14:31:28
Message-ID: 20100923143128.10559.20716 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5431/
-----------------------------------------------------------
Review request for KOffice.
Summary
-------
This patch makes the attribute() and property() methods in KoGenStyle publi=
c instead of private. The main use-case for this class is of course only to=
set properies and attributes, then insert styles in a KoGenStyles and forg=
et about the actual contents of the style, but sometimes when creating odf =
files it is useful to be able to later lookup properties of earlier generat=
ed styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merg=
ed cells is stored in one cell style in odf, but in the xlsx file it is a c=
ombination of properties from the cell styles for all cells that are merged=
. With this change I can simply merge the cell styles when I know that cell=
s are merged, without having to keep the cell-styles around in another form=
at than the KoGenStyle that already contains all relevant information anywa=
y.
Diffs
-----
trunk/koffice/libs/odf/KoGenStyle.h 1178191 =
Diff: http://svn.reviewboard.kde.org/r/5431/diff
Testing
-------
Thanks,
Marijn
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5431/">http://svn.reviewboard.kde.org/r/5431/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Marijn Kruisselbrink.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes the attribute() and property() methods in KoGenStyle \
public instead of private. The main use-case for this class is of course only to set \
properies and attributes, then insert styles in a KoGenStyles and forget about the \
actual contents of the style, but sometimes when creating odf files it is useful to \
be able to later lookup properties of earlier generated styles, without having to \
double-store that information. For example in the xlsx filter this is used because \
the cell style for merged cells is stored in one cell style in odf, but in the xlsx \
file it is a combination of properties from the cell styles for all cells that are \
merged. With this change I can simply merge the cell styles when I know that cells \
are merged, without having to keep the cell-styles around in another format than the \
KoGenStyle that already contains all relevant information anyway.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/odf/KoGenStyle.h <span style="color: \
grey">(1178191)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5431/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic