--===============1400649115== Content-Type: multipart/alternative; boundary="===============1562237907328090325==" --===============1562237907328090325== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5431/ ----------------------------------------------------------- Review request for KOffice. Summary ------- This patch makes the attribute() and property() methods in KoGenStyle publi= c instead of private. The main use-case for this class is of course only to= set properies and attributes, then insert styles in a KoGenStyles and forg= et about the actual contents of the style, but sometimes when creating odf = files it is useful to be able to later lookup properties of earlier generat= ed styles, without having to double-store that information. For example in the xlsx filter this is used because the cell style for merg= ed cells is stored in one cell style in odf, but in the xlsx file it is a c= ombination of properties from the cell styles for all cells that are merged= . With this change I can simply merge the cell styles when I know that cell= s are merged, without having to keep the cell-styles around in another form= at than the KoGenStyle that already contains all relevant information anywa= y. Diffs ----- trunk/koffice/libs/odf/KoGenStyle.h 1178191 = Diff: http://svn.reviewboard.kde.org/r/5431/diff Testing ------- Thanks, Marijn --===============1562237907328090325== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5431/

Review request for KOffice.

By Marijn Kruisselbrink.

Descripti= on

This patch makes the attribute() and property() methods in K=
oGenStyle public instead of private. The main use-case for this class is of=
 course only to set properies and attributes, then insert styles in a KoGen=
Styles and forget about the actual contents of the style, but sometimes whe=
n creating odf files it is useful to be able to later lookup properties of =
earlier generated styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merg=
ed cells is stored in one cell style in odf, but in the xlsx file it is a c=
ombination of properties from the cell styles for all cells that are merged=
. With this change I can simply merge the cell styles when I know that cell=
s are merged, without having to keep the cell-styles around in another form=
at than the KoGenStyle that already contains all relevant information anywa=
y.

Diffs=

trunk/koffice/libs/odf/KoGenStyle.h (11781= 91)

--===============1562237907328090325==-- --===============1400649115== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1400649115==--