[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Allow floating point font sizes
From: "Robert Knight" <robertknight () gmail ! com>
Date: 2009-10-24 18:27:32
Message-ID: 20091024182732.4101.77739 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1964/#review2797
-----------------------------------------------------------
/trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp
<http://reviewboard.kde.org/r/1964/#comment2150>
Where does the '60' come from?
/trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp
<http://reviewboard.kde.org/r/1964/#comment2152>
Rather than repeating the scaling factor in multiple places I suggest adding \
functions to set the slider range given a font point size range.
eg: setFontSliderRange(int minPointSize, int maxPointSize) and \
setFontSliderValue(qreal pointSize) which do the scaling internally.
/trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp
<http://reviewboard.kde.org/r/1964/#comment2153>
Can you clarify the comment about anti-aliasing settings. When the user has \
anti-aliasing turned off in their settings (by unchecking the 'Smooth fonts' \
checkbox) the preview should not be aliased.
- Robert
On 2009-10-24 16:02:09, Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1964/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 16:02:09)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> This change fixes the following problems:
>
> - Konsole did not support floating point font sizes in the Profile Editor
> - the font preview did not respect the "antialias" setting when the _tempProfile \
> did not have that setting
> - when cancelling the font dialog the antialias setting was cleared
> - when the choosen font size was 7, but "smallestReadableFont" size was 8, the \
> slider was stuck
> - the maximum slider value only grew as large as the selected font, making it \
> useless to select a larger font using the slider
> I removed the "smallestReadableFont" size query for two reasons:
>
> - monospaced fonts are often clearer to read, so it makes sense to allow smaller \
> sizes
> - the "Decrease Font Size" action did not respect it anyway
>
>
> This addresses bug 173000.
> https://bugs.kde.org/show_bug.cgi?id=173000
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp 1039697
> /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1039697
>
> Diff: http://reviewboard.kde.org/r/1964/diff
>
>
> Testing
> -------
>
> Compiles and works good :)
>
>
> Thanks,
>
> Christoph
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic