[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Allow floating point font sizes
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-10-24 16:02:09
Message-ID: 20091024160209.640.81940 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1964/
-----------------------------------------------------------

(Updated 2009-10-24 16:02:09.057601)


Review request for Konsole.


Changes
-------

Forgot this: Also use pointSizeF() on increase/decrease actions, so that increase, \
then decrease restores original font size.


Summary
-------

This change fixes the following problems:

- Konsole did not support floating point font sizes in the Profile Editor
- the font preview did not respect the "antialias" setting when the _tempProfile did \
                not have that setting
- when cancelling the font dialog the antialias setting was cleared
- when the choosen font size was 7, but "smallestReadableFont" size was 8, the slider \
                was stuck
- the maximum slider value only grew as large as the selected font, making it useless \
to select a larger font using the slider

I removed the "smallestReadableFont" size query for two reasons:

- monospaced fonts are often clearer to read, so it makes sense to allow smaller \
                sizes
- the "Decrease Font Size" action did not respect it anyway


This addresses bug 173000.
    https://bugs.kde.org/show_bug.cgi?id=173000


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp 1039697 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1039697 

Diff: http://reviewboard.kde.org/r/1964/diff


Testing
-------

Compiles and works good :)


Thanks,

Christoph

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]