From python-list Sun Feb 19 19:43:52 2017 From: Dotan Cohen Date: Sun, 19 Feb 2017 19:43:52 +0000 To: python-list Subject: Re: WANT: bad code in python (for refactoring example) Message-Id: X-MARC-Message: https://marc.info/?l=python-list&m=148753351211692 There are some nice changes in here. You can mention to the students that I really appreciated the work done on the menu loop. You took an example of code that had grown piecemeal and become reasonably unmaintainable, and refactored it to be very maintainable in the future. Good luck to all class participants! On Fri, Feb 17, 2017 at 3:47 PM, Makoto Kuwata wrote: > On Thu, Feb 16, 2017 at 6:34 AM, Dotan Cohen wrote: > >> I think that we can help each other! This is my own code, back when I >> was writing Python like PHP: >> https://github.com/dotancohen/burton > > > Year, this is a good example code for me to do refactoring. > > I created a pull request. This will be shown to my students. > > https://github.com/dotancohen/burton/pull/20/files > > I hope you favor this PR. > > -- > regards, > makoto kuwata > -- > https://mail.python.org/mailman/listinfo/python-list -- Dotan Cohen http://gibberish.co.il http://what-is-what.com -- https://mail.python.org/mailman/listinfo/python-list