'Re: Review Request 125175: Change close icon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 125175: Change close icon
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-09-14 8:10:59
Message-ID: 20150914081059.3546.81093 () mimi ! kde ! org
[Download RAW message or body]

--===============6507842851820695886==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125175/#review85349
-----------------------------------------------------------

Ship it!

Ship It!

- Milian Wolff

On Sept. 11, 2015, 8:36 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125175/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 8:36 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Hi,
> 
> we changed our window-close icon to make it the same icons like tab close, window \
> decoration close icon, ... but now it doesn't fit in the toolbar so we add an \
> document-close icon 
> here you see the close icons including the document-close icon.
> 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Kate.png
> 
> are the close icon from the kate, kwrite toolbar is used anywhere else or it the \
> diff still working? I don't compile sorry 
> 
> Diffs
> -----
> 
> addons/filetree/katefiletree.cpp 0c1502c 
> 
> Diff: https://git.reviewboard.kde.org/r/125175/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> andreas kainz
> 
> 

--===============6507842851820695886==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125175/">https://git.reviewboard.kde.org/r/125175/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Milian Wolff</p>

<br />
<p>On September 11th, 2015, 8:36 p.m. UTC, andreas kainz wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By andreas kainz.</div>

<p style="color: grey;"><i>Updated Sept. 11, 2015, 8:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">we changed our \
window-close icon to make it the same icons like tab close, window decoration close \
icon, ... but now it doesn't fit in the toolbar so we add an document-close icon</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">here you see the close icons including the \
document-close icon.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Kate.png</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">are the close icon from the kate, kwrite toolbar is used anywhere else or \
it the diff still working? I don't compile sorry</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/filetree/katefiletree.cpp <span style="color: grey">(0c1502c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125175/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6507842851820695886==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 