'Re: Review Request 124903: Merge allocation of TextLineData and ref count block.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 124903: Merge allocation of TextLineData and ref count block.
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-08-25 8:32:35
Message-ID: 20150825083235.4103.89083 () mimi ! kde ! org
[Download RAW message or body]

--===============9020780136117687418==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124903/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 8:32 a.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Changes
-------

Submitted with commit a3a30df7bc0a803460ca3a1e7af3a7db8e05133f by Milian Wolff to \
branch master.

Repository: ktexteditor

Description
-------

This removes one allocation per line, which for large files can
lead to a significant performance win.

The potential downside would be that weak pointers keep the line
alive, but we do not use that anywhere afaik.

Diffs
-----

  src/buffer/katetextblock.cpp 3c8cf316757e83cda943d623cb3b9b163f0d0840 

Diff: https://git.reviewboard.kde.org/r/124903/diff/

Testing
-------

Thanks,

Milian Wolff

--===============9020780136117687418==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124903/">https://git.reviewboard.kde.org/r/124903/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2015, 8:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a3a30df7bc0a803460ca3a1e7af3a7db8e05133f by Milian \
Wolff to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This removes one allocation per line, which for large files can lead to \
a significant performance win.

The potential downside would be that weak pointers keep the line
alive, but we do not use that anywhere afaik.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/buffer/katetextblock.cpp <span style="color: \
grey">(3c8cf316757e83cda943d623cb3b9b163f0d0840)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124903/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9020780136117687418==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 