'Re: Review Request 124370: Support QML multi-line strings.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 124370: Support QML multi-line strings.
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-07-16 16:09:50
Message-ID: 20150716160950.27368.18973 () mimi ! kde ! org
[Download RAW message or body]

--===============3350499277114871287==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124370/
-----------------------------------------------------------

(Updated July 16, 2015, 4:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Changes
-------

Submitted with commit 3fdddc327b2d2ab8163d4874f9d4d4d3b49e49bc by Milian Wolff to \
branch master.

Repository: ktexteditor

Description
-------

To do so, we have to copy the slightly adapted String context
from JavaScript.xml. Furthermore, we must not leak into the JavaScript
context when we hit a {, rather we copy that as well, otherwise the
JavaScript string would be detected.

Potentially, we have to think about removing the JavaScript include
alltogether and duplicating the stuff in the QML highlighter to really
support the JavaScript subset of QML properly.

Diffs
-----

  src/syntax/data/qml.xml 1f0ad8f084b2ee7b7da67f8c86e34878d642e02a 

Diff: https://git.reviewboard.kde.org/r/124370/diff/

Testing
-------

Thanks,

Milian Wolff

--===============3350499277114871287==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124370/">https://git.reviewboard.kde.org/r/124370/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated July 16, 2015, 4:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 3fdddc327b2d2ab8163d4874f9d4d4d3b49e49bc by Milian \
Wolff to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To do so, we have to copy the slightly adapted String context from \
JavaScript.xml. Furthermore, we must not leak into the JavaScript context when we hit \
a {, rather we copy that as well, otherwise the JavaScript string would be detected.

Potentially, we have to think about removing the JavaScript include
alltogether and duplicating the stuff in the QML highlighter to really
support the JavaScript subset of QML properly.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/syntax/data/qml.xml <span style="color: \
grey">(1f0ad8f084b2ee7b7da67f8c86e34878d642e02a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124370/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3350499277114871287==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 