[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: [PATCH] non-linear timelines for effects
From:       Sebastian Kuegler <sebas () kde ! org>
Date:       2008-05-02 23:32:15
Message-ID: 200805030132.15621.sebas () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 30 April 2008 14:12:08 Martin Graesslin wrote:
> Am Mittwoch, 30. April 2008 13:13:54 schrieb Sebastian Kuegler:
> > Does the attached patch help? (Not tested ...)
>
> The patch helps - solves the mentioned bug. But the patch looks a little
> bit much linear. Shouldn't it respect the used curve?

Progress and time of the TimeLine is independant from the curveshape, the 
curveshape is taken into account from the value() method. Progress (a double 
between 0.0 and 1.0) and Time (an int, msec between 0 and duration) are 
actually different notations for the x-axis if you imagine the TimeLine curve 
as a graph. The value is a double between 0.0 and 1.0, interpolated by the 
curve. (And for the LinearCurve, value and progress are the same.) So the 
patch only needs to keep m_Time and m_Progress in the TimeLine in sync, a 
stupid omission from my side :-)

I've made this more clear in the API docs and will commit it shortly. Thanks 
for spotting it!
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

["signature.asc" (application/pgp-signature)]

_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]