'Review Request: Fix for shape paste endless loop in Krita'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Fix for shape paste endless loop in Krita
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2010-10-31 12:20:21
Message-ID: 20101031122021.24652.76814 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5733/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

The patch fixes a problem when copy and paste a shape in Krita. The problem is that \
KoShapePaste does some calculation to have a little offset between old shape and \
pasted shape. For that it expects that the shape isn't in the shape manager \
(KoShapePaste line 110 and following). In Krita the shape layer model does add the \
shape in addShape. The patch changes that so the shape is not added in the model, but \
in KisShapeController and KisShapeLayerShapePaste.

This addresses bug 255682.
    https://bugs.kde.org/show_bug.cgi?id=255682

Diffs
-----

  /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1191387 
  /trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1191387 
  /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h 1191387 

Diff: http://svn.reviewboard.kde.org/r/5733/diff

Testing
-------

Tested with copy and paste.

Thanks,

Sven

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5733/">http://svn.reviewboard.kde.org/r/5733/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch fixes a problem when copy and paste a shape in Krita. The \
problem is that KoShapePaste does some calculation to have a little offset between \
old shape and pasted shape. For that it expects that the shape isn&#39;t in the shape \
manager (KoShapePaste line 110 and following). In Krita the shape layer model does \
add the shape in addShape. The patch changes that so the shape is not added in the \
model, but in KisShapeController and KisShapeLayerShapePaste.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with copy and paste.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=255682">255682</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp <span style="color: \
grey">(1191387)</span></li>

 <li>/trunk/koffice/krita/ui/flake/kis_shape_layer.cc <span style="color: \
grey">(1191387)</span></li>

 <li>/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h <span style="color: \
grey">(1191387)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5733/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 