[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Support for hyperlinks in kpresenter presentation
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-10-22 17:08:32
Message-ID: 20101022170832.22192.16289 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-20 15:41:46, Thomas Zander wrote:
> > The requested feature is already available in the text tool the request=
to be able to click on links in kpresenters presentation tool should follo=
w the same design if it wants to do the same thing.
> > Making this into an action sounds wrong to me because that means the fu=
nctionality becomes available for all tools and that goes against the conce=
pt of flake which is that tools are specialized by the functionality that t=
he user wants the work with at this moment.
> =
> Matus Hanzes wrote:
> One problem with the TextTool is that I don't want to have IBeamCurso=
r when mouse pointer is hovering over text in text shape.
> =
> Another problem is that I want to handle all mouse events in kpresent=
er when the mouse is over TextShape but not over hyperlink.(go to the next =
slide) And it is not possible because I can't get the information out of th=
e TextTool.
> =
> If you know how to get the information that mouse pointer is over hyp=
erlink out of TextShape. Then tell me.
> =
>
Sorry if I was not clear; I didn't mean you should use the text tool, I sai=
d the presentation tools should use the same design that the text tool alre=
ady uses.
What I meant with that is because both the presentation tool and the text t=
ool should handle urls, but no other tools should handle URLS those two too=
ls should have code for this behavior.
So please add some code to the presentation tool to check if there is a tex=
t shape where the user clicked and then use the public APIs to figure out t=
he URL and handle that accordingly.
How does that sound?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5633/#review8273
-----------------------------------------------------------
On 2010-10-15 14:40:48, Matus Hanzes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5633/
> -----------------------------------------------------------
> =
> (Updated 2010-10-15 14:40:48)
> =
> =
> Review request for KOffice, Thorsten Zachmann and Thomas Zander.
> =
> =
> Summary
> -------
> =
> Support for hyperlinks in presentation mode consist of two problems
> 1. Change the cursor from ArrowCursor to PointingHandCursur, when the cur=
sor is over the hyperlink.
> 2. Run the hyperlink, when the hyperlink is clicked.
> =
> I have used KoShape EventAction framework for accessing the data inside T=
extShape.
> To work with hyperlinks in TextEvenAction I have used code from TextTool.
> =
> I will do unit tests after this solution is approved.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/kpresenter/part/KPrPresentationTool.cpp 1186176 =
> trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction=
.h 1186176 =
> trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction=
.cpp 1186176 =
> trunk/koffice/libs/flake/KoEventAction.h 1186176 =
> trunk/koffice/plugins/textshape/CMakeLists.txt 1186176 =
> trunk/koffice/plugins/textshape/TextEventAction.h PRE-CREATION =
> trunk/koffice/plugins/textshape/TextEventAction.cpp PRE-CREATION =
> trunk/koffice/plugins/textshape/TextShape.h 1186176 =
> trunk/koffice/plugins/textshape/TextShape.cpp 1186176 =
> trunk/koffice/plugins/textshape/tests/CMakeLists.txt 1186176 =
> trunk/koffice/plugins/videoshape/VideoEventAction.h 1186176 =
> trunk/koffice/plugins/videoshape/VideoEventAction.cpp 1186176 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5633/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matus
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5633/">http://svn.reviewboard.kde.org/r/5633/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 20th, 2010, 3:41 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The requested feature is already available in the text tool the request \
to be able to click on links in kpresenters presentation tool should follow the same \
design if it wants to do the same thing. Making this into an action sounds wrong to \
me because that means the functionality becomes available for all tools and that goes \
against the concept of flake which is that tools are specialized by the functionality \
that the user wants the work with at this moment.</pre> </blockquote>
<p>On October 21st, 2010, 6:45 a.m., <b>Matus Hanzes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One problem with the \
TextTool is that I don't want to have IBeamCursor when mouse pointer is hovering \
over text in text shape.
Another problem is that I want to handle all mouse events in kpresenter when the \
mouse is over TextShape but not over hyperlink.(go to the next slide) And it is not \
possible because I can't get the information out of the TextTool.
If you know how to get the information that mouse pointer is over hyperlink out of \
TextShape. Then tell me.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry if I was not \
clear; I didn't mean you should use the text tool, I said the presentation tools \
should use the same design that the text tool already uses.
What I meant with that is because both the presentation tool and the text tool should \
handle urls, but no other tools should handle URLS those two tools should have code \
for this behavior. So please add some code to the presentation tool to check if there \
is a text shape where the user clicked and then use the public APIs to figure out the \
URL and handle that accordingly.
How does that sound?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 15th, 2010, 2:40 p.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice, Thorsten Zachmann and Thomas Zander.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated 2010-10-15 14:40:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support for hyperlinks in presentation mode consist of two problems \
1. Change the cursor from ArrowCursor to PointingHandCursur, when the cursor is over \
the hyperlink. 2. Run the hyperlink, when the hyperlink is clicked.
I have used KoShape EventAction framework for accessing the data inside TextShape.
To work with hyperlinks in TextEvenAction I have used code from TextTool.
I will do unit tests after this solution is approved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kpresenter/part/KPrPresentationTool.cpp <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.h <span \
style="color: grey">(1186176)</span></li>
<li>trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.cpp \
<span style="color: grey">(1186176)</span></li>
<li>trunk/koffice/libs/flake/KoEventAction.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/CMakeLists.txt <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/TextEventAction.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/koffice/plugins/textshape/TextEventAction.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.cpp <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/tests/CMakeLists.txt <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/videoshape/VideoEventAction.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/videoshape/VideoEventAction.cpp <span style="color: \
grey">(1186176)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5633/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic