This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5667/

Ship it!

Nice patch.  After committing it, I suggest that you also add calls to this check from the various lvl<1-9>pPr tags.  I guess that bullet colors are especially important in lists.

trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h (Diff revision 1)
KoFilter::ConversionStatus MSOOXML_CURRENT_CLASS::read_buChar()
		4475	- lvl1pPr (§21.1.2.4.13)

Especially for the bullet colors, it would not hurt at all if  the lvl<x>pPr was supported as well.

- Inge

On October 20th, 2010, 8:12 a.m., nandita suri wrote:

Review request for KOffice.

By nandita suri.

Updated 2010-10-20 08:12:46

Description

Color of the bullet is not handled in msooxml filters.
Handled buClr and two of its child elements srgbClr and schemeClr.

Diffs

trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlUtils.h (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp (1187692)

View Diff