[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: Support for hyperlinks in kpresenter presentation mode
From: "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date: 2010-10-15 14:40:48
Message-ID: 20101015144048.18321.24378 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5633/
-----------------------------------------------------------
Review request for KOffice, Thorsten Zachmann and Thomas Zander.
Summary
-------
Support for hyperlinks in presentation mode consist of two problems
1. Change the cursor from ArrowCursor to PointingHandCursur, when the curso=
r is over the hyperlink.
2. Run the hyperlink, when the hyperlink is clicked.
I have used KoShape EventAction framework for accessing the data inside Tex=
tShape.
To work with hyperlinks in TextEvenAction I have used code from TextTool.
I will do unit tests after this solution is approved.
Diffs
-----
trunk/koffice/kpresenter/part/KPrPresentationTool.cpp 1186176 =
trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.h=
1186176 =
trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.c=
pp 1186176 =
trunk/koffice/libs/flake/KoEventAction.h 1186176 =
trunk/koffice/plugins/textshape/CMakeLists.txt 1186176 =
trunk/koffice/plugins/textshape/TextEventAction.h PRE-CREATION =
trunk/koffice/plugins/textshape/TextEventAction.cpp PRE-CREATION =
trunk/koffice/plugins/textshape/TextShape.h 1186176 =
trunk/koffice/plugins/textshape/TextShape.cpp 1186176 =
trunk/koffice/plugins/textshape/tests/CMakeLists.txt 1186176 =
trunk/koffice/plugins/videoshape/VideoEventAction.h 1186176 =
trunk/koffice/plugins/videoshape/VideoEventAction.cpp 1186176 =
Diff: http://svn.reviewboard.kde.org/r/5633/diff
Testing
-------
Thanks,
Matus
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5633/">http://svn.reviewboard.kde.org/r/5633/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice, Thorsten Zachmann and Thomas Zander.</div>
<div>By Matus Hanzes.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support for hyperlinks in presentation mode consist of two problems \
1. Change the cursor from ArrowCursor to PointingHandCursur, when the cursor is over \
the hyperlink. 2. Run the hyperlink, when the hyperlink is clicked.
I have used KoShape EventAction framework for accessing the data inside TextShape.
To work with hyperlinks in TextEvenAction I have used code from TextTool.
I will do unit tests after this solution is approved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kpresenter/part/KPrPresentationTool.cpp <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.h <span \
style="color: grey">(1186176)</span></li>
<li>trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.cpp \
<span style="color: grey">(1186176)</span></li>
<li>trunk/koffice/libs/flake/KoEventAction.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/CMakeLists.txt <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/TextEventAction.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/koffice/plugins/textshape/TextEventAction.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/TextShape.cpp <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/textshape/tests/CMakeLists.txt <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/videoshape/VideoEventAction.h <span style="color: \
grey">(1186176)</span></li>
<li>trunk/koffice/plugins/videoshape/VideoEventAction.cpp <span style="color: \
grey">(1186176)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5633/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic