[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: SpellChecker remove all misspelled when disabled.
From: "Christoph Goerlich" <chgoerlich () gmx ! de>
Date: 2010-07-28 19:21:25
Message-ID: 20100728192125.19095.71113 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-28 05:32:32, Boudewijn Rempt wrote:
> > Apart from the piddling little issue that the style guide says that the opening \
> > brace of if and for blocks needs to be on the same line, not a new line, I think \
> > this looks pretty good. I tested it and it works fine. Can you commit yourself?
Yes, and I have the opening braces reformatted according to the style guide.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4762/#review6721
-----------------------------------------------------------
On 2010-07-27 18:33:32, Christoph Goerlich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4762/
> -----------------------------------------------------------
>
> (Updated 2010-07-27 18:33:32)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> I have done a Junior Job (see http://wiki.koffice.org/index.php?title=Junior_Jobs \
> in section kword "Spellchecker should remove all misspelled words when the \
> spellchecker is disabled.").
>
> Diffs
> -----
>
> trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp 1154371
>
> Diff: http://reviewboard.kde.org/r/4762/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4762/">http://reviewboard.kde.org/r/4762/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2010, 5:32 a.m., <b>Boudewijn \
Rempt</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Apart from the piddling little issue that the \
style guide says that the opening brace of if and for blocks needs to be on the same \
line, not a new line, I think this looks pretty good. I tested it and it works fine. \
Can you commit yourself?</pre> </blockquote>
</blockquote>
<pre>Yes, and I have the opening braces reformatted according to the style \
guide.</pre> <br />
<p>- Christoph</p>
<br />
<p>On July 27th, 2010, 6:33 p.m., Christoph Goerlich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Christoph Goerlich.</div>
<p style="color: grey;"><i>Updated 2010-07-27 18:33:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">I have done a Junior Job (see \
http://wiki.koffice.org/index.php?title=Junior_Jobs in section kword \
"Spellchecker should remove all misspelled words when the spellchecker is \
disabled.").</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp <span style="color: \
grey">(1154371)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4762/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic