[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: It prevens kword make INFINITY LOOP in layout. New
From: "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date: 2010-06-30 11:35:27
Message-ID: 20100630113527.17736.68228 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-06-29 23:34:31, Thomas Zander wrote:
> > Could someone that knows more about loading ODF please review this one?
>
> Thorsten Zachmann wrote:
> From what I found out when looking at that is the following: In odf it is not \
> described what should happen when svg:width is not specified. However it is valid \
> to have no svg:width set. From looking at svg which is used here I see that if no \
> width is given it assumes 100% which means it needs to be as big as the stuff it \
> contains. Does that patch return the correct value to the width or does it just \
> work around the problem as it return a big enough width?
Patch sets outer frame width based on inner frame width. Then we can see full inner \
frame and layout doesn't loop. This is what we want. Patch takes first inner frame \
width which is found. In case a different situation (more inner frames or different \
objects) we can modify patch to use max inner width which can be found.
- Pavol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4263/#review6321
-----------------------------------------------------------
On 2010-06-17 07:36:27, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4263/
> -----------------------------------------------------------
>
> (Updated 2010-06-17 07:36:27)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This patch solves possible loop problem when frame doesn't fit in layout, because \
> hasn't set width parameter. Default parameter had smaller width. Outer frame gets \
> width parameter from inner frame. If gets width from first inner one. Possibly it \
> can be changed to get width from inner frame with maximum width. (bug fix for: \
> https://bugs.kde.org/show_bug.cgi?id=238665)
>
> Diffs
> -----
>
> /trunk/koffice/libs/flake/KoShape.cpp 1138552
>
> Diff: http://reviewboard.kde.org/r/4263/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4263/">http://reviewboard.kde.org/r/4263/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 29th, 2010, 11:34 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Could someone that knows more about loading ODF \
please review this one?</pre> </blockquote>
<p>On June 30th, 2010, 5:19 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>From what I found out when looking at that is the following: In odf it \
is not described what should happen when svg:width is not specified. However it is \
valid to have no svg:width set. From looking at svg which is used here I see that if \
no width is given it assumes 100% which means it needs to be as big as the stuff it \
contains. Does that patch return the correct value to the width or does it just work \
around the problem as it return a big enough width?</pre> </blockquote>
</blockquote>
<pre>Patch sets outer frame width based on inner frame width. Then we can see full \
inner frame and layout doesn't loop. This is what we want. Patch takes first \
inner frame width which is found. In case a different situation (more inner frames or \
different objects) we can modify patch to use max inner width which can be \
found.</pre> <br />
<p>- Pavol</p>
<br />
<p>On June 17th, 2010, 7:36 a.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-06-17 07:36:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch solves possible loop problem when \
frame doesn't fit in layout, because hasn't set width parameter. Default \
parameter had smaller width. Outer frame gets width parameter from inner frame. If \
gets width from first inner one. Possibly it can be changed to get width from inner \
frame with maximum width. (bug fix for: \
https://bugs.kde.org/show_bug.cgi?id=238665)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/flake/KoShape.cpp <span style="color: \
grey">(1138552)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4263/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic