'Re: Review Request: speed up character style loading'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: speed up character style loading
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-06-30 6:47:46
Message-ID: 20100630064746.7609.34321 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4491/#review6324
-----------------------------------------------------------

Ship it!

Profiled with valgrind on two documents, compared before and after and ther=
e is a nice improvement.

- Boudewijn

On 2010-06-29 09:43:04, Thorsten Zachmann wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4491/
> -----------------------------------------------------------
> =

> (Updated 2010-06-29 09:43:04)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Speed up character style loading be not looking up the styles multiple ti=
me instead only lookup once and decide on the return value what to do.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1143662 =

> =

> Diff: http://reviewboard.kde.org/r/4491/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Thorsten
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4491/">http://reviewboard.kde.org/r/4491/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre>Profiled with valgrind on two documents, compared before and after and there is \
a nice improvement.</pre>  <br />

<p>- Boudewijn</p>

<br />
<p>On June 29th, 2010, 9:43 a.m., Thorsten Zachmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>

<p style="color: grey;"><i>Updated 2010-06-29 09:43:04</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Speed up character style loading be not \
looking up the styles multiple time instead only lookup once and decide on the return \
value what to do.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp <span style="color: \
grey">(1143662)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4491/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 