'Re: Review Request: Fix for stroke workaround'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix for stroke workaround
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-06-25 22:34:01
Message-ID: 20100625223401.13692.85461 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4458/#review6290
-----------------------------------------------------------

Ship it!

thanks for fast fix :)

- Thomas

On 2010-06-25 21:30:32, Sven Langkamp wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4458/
> -----------------------------------------------------------
> =

> (Updated 2010-06-25 21:30:32)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Patch fixes the stroke workaround regression pointed out by Thomas. Limit=
s the workaround to path shapes.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/flake/KoOdfWorkaround.h 1141841 =

>   trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1141861 =

>   trunk/koffice/libs/flake/KoShape.cpp 1141841 =

> =

> Diff: http://reviewboard.kde.org/r/4458/diff
> =

> =

> Testing
> -------
> =

> Images from bug 122232 load without stroke.
> =

> =

> Thanks,
> =

> Sven
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4458/">http://reviewboard.kde.org/r/4458/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre>thanks for fast fix :)</pre>
 <br />

<p>- Thomas</p>

<br />
<p>On June 25th, 2010, 9:30 p.m., Sven Langkamp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<p style="color: grey;"><i>Updated 2010-06-25 21:30:32</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Patch fixes the stroke workaround regression \
pointed out by Thomas. Limits the workaround to path shapes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Images from bug 122232 load without \
stroke.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/flake/KoOdfWorkaround.h <span style="color: \
grey">(1141841)</span></li>

 <li>trunk/koffice/libs/flake/KoOdfWorkaround.cpp <span style="color: \
grey">(1141861)</span></li>

 <li>trunk/koffice/libs/flake/KoShape.cpp <span style="color: \
grey">(1141841)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4458/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 