[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    workaround
From:       Thomas Zander <zander () kde ! org>
Date:       2010-06-25 20:59:34
Message-ID: 201006252259.35021.zander () kde ! org
[Download RAW message or body]

Hey,

this commit caused a regression in loading images. They all have a black 
outline now.
See the attached document on bug 122232 for an example.

Could you please look at this? Thanks!

On Wednesday 23. June 2010 12.16.09 Sven Langkamp wrote:
> SVN commit 1141714 by langkamp:
> 
> add workaround in case the stroke-color wasn't save
> CCBUG:239676
> 
> 
>  M  +9 -1      KoOdfWorkaround.cpp
> 
> 
> --- trunk/koffice/libs/flake/KoOdfWorkaround.cpp #1141713:1141714
> @@ -124,8 +124,8 @@
>  {
>      bool fixed = false;
> 
> +    KoStyleStack &styleStack = context.odfLoadingContext().styleStack();
>      if ( element.prefix() == "chart" ) {
> -        KoStyleStack &styleStack =
> context.odfLoadingContext().styleStack(); styleStack.save();
> 
>          bool hasStyle = element.hasAttributeNS(KoXmlNS::chart,
> "style-name"); @@ -161,7 +161,15 @@
>          }
> 
>          styleStack.restore();
> +    } else {
> +        const QString strokeColor(styleStack.property(KoXmlNS::draw,
> "stroke-color")); +        if(strokeColor.isEmpty()) {
> +            pen.setColor( Qt::black );
> +        } else {
> +            pen.setColor(styleStack.property(KoXmlNS::svg,
> "stroke-color")); }
> +        fixed = true;
> +    }
> 
>      return fixed;
>  }

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]