[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Show docker action in KoMainWindow
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-06-24 14:20:51
Message-ID: 20100624142051.6852.78477 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4454/#review6261
-----------------------------------------------------------
Ship it!
Fine with me. Krita users love it :-)
/trunk/koffice/plugins/pictureshape/PictureShape.h
<http://reviewboard.kde.org/r/4454/#comment5907>
I bet this doesn't belong.
- Boudewijn
On 2010-06-24 14:20:32, Sven Langkamp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4454/
> -----------------------------------------------------------
> =
> (Updated 2010-06-24 14:20:32)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Moves the Show dockers action to KoMainWindow. Allows to hide the dockers=
including toolbox.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/kpresenter/kpresenter.rc 1141841 =
> /trunk/koffice/krita/krita.rc 1141841 =
> /trunk/koffice/krita/ui/kis_view2.cpp 1141841 =
> /trunk/koffice/kword/part/kword.rc 1141841 =
> /trunk/koffice/libs/main/KoMainWindow.cpp 1141841 =
> =
> Diff: http://reviewboard.kde.org/r/4454/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Sven
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4454/">http://reviewboard.kde.org/r/4454/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Fine with me. Krita users love it :-)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4454/diff/1/?file=29729#file29729line67" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/plugins/pictureshape/PictureShape.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">67</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="k">virtual</span> <span class="n">QString</span> <span \
class="n">saveStyle</span><span class="p">(</span><span class="n">KoGenStyle</span> \
<span class="o">&</span><span class="n">style</span><span class="p">,</span> \
<span class="n">KoShapeSavingContext</span> <span class="o">&</span><span \
class="n">context</span><span class="p">)</span> <span class="k">const</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">I bet this doesn't belong.</pre>
</div>
<br />
<p>- Boudewijn</p>
<br />
<p>On June 24th, 2010, 2:20 p.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated 2010-06-24 14:20:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Moves the Show dockers action to KoMainWindow. \
Allows to hide the dockers including toolbox.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kpresenter/kpresenter.rc <span style="color: \
grey">(1141841)</span></li>
<li>/trunk/koffice/krita/krita.rc <span style="color: grey">(1141841)</span></li>
<li>/trunk/koffice/krita/ui/kis_view2.cpp <span style="color: \
grey">(1141841)</span></li>
<li>/trunk/koffice/kword/part/kword.rc <span style="color: \
grey">(1141841)</span></li>
<li>/trunk/koffice/libs/main/KoMainWindow.cpp <span style="color: \
grey">(1141841)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4454/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic