[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Avoid #elif without expression when HAVE_FUNC_FINITE
From:       Ingmar Vanhassel <ingmar () exherbo ! org>
Date:       2009-09-24 16:38:10
Message-ID: 1253810254-sup-6757 () cannonball
[Download RAW message or body]

Excerpts from Ingmar Vanhassel's message of Fri Sep 04 21:22:42 +0200 2009:
> ---
>  src/ustring.cpp |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> Casper,
> 
> Could you please commit this patch too. It fixes my build with GCC 4.4.x, as we
> discussed on #koffice a few days ago.
> 
> diff --git a/src/ustring.cpp b/src/ustring.cpp
> index 2e5a61d..ce27091 100644
> --- a/src/ustring.cpp
> +++ b/src/ustring.cpp
> @@ -78,9 +78,9 @@ bool wvWare::isPosInf(double d)
>  {
>  #if defined(HAVE_FUNC_ISINF)
>    return (isinf(d) == 1);
> -#elif HAVE_FUNC_FINITE
> +#elif defined(HAVE_FUNC_FINITE)
>    return finite(d) == 0 && d == d; // ### can we distinguish between + and - ?
> -#elif HAVE_FUNC__FINITE
> +#elif defined(HAVE_FUNC__FINITE)
>    return _finite(d) == 0 && d == d; // ###
>  #else
>    return false;
> @@ -91,9 +91,9 @@ bool wvWare::isNegInf(double d)
>  {
>  #if defined(HAVE_FUNC_ISINF)
>    return (isinf(d) == -1);
> -#elif HAVE_FUNC_FINITE
> +#elif defined(HAVE_FUNC_FINITE)
>    return finite(d) == 0 && d == d; // ###
> -#elif HAVE_FUNC__FINITE
> +#elif defined(HAVE_FUNC__FINITE)
>    return _finite(d) == 0 && d == d; // ###
>  #else
>    return false;

Poke! :)

-- 
Exherbo KDE, X.org maintainer
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]