--===============0455773098==
Content-Type: multipart/signed;
  boundary="nextPart1372783.Fl2OfgSKSo";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1372783.Fl2OfgSKSo
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 26. October 2008 04:09:58 Thorsten Zachmann wrote:
> On Sunday 26 October 2008, Thomas Zander wrote:
> > SVN commit 875905 by zander:
> >
> > After the refactor with dataMaps we started seeing various crashes,
> > this fixes the one in KWFrameLayout and removes code in the scripting
> > engine that no longer can work.
> >
> >  M  +4 -1      part/frames/KWFrameLayout.cpp
> >  M  +0 -31     plugins/scripting/FrameSet.h
> >  M  +0 -12     plugins/scripting/Module.cpp
> >  M  +1 -14     plugins/scripting/Module.h
> >
> >
> > --- trunk/koffice/kword/part/frames/KWFrameLayout.cpp #875904:875905
> > @@ -499,7 +499,10 @@
> >      Q_ASSERT(page.isValid());
> >      KoShapeFactory *factory =3D
> > KoShapeRegistry::instance()->value(TextShape_SHAPEID);
> > Q_ASSERT(factory); -    KoShape *shape =3D
> > factory->createDefaultShapeAndInit(m_document->dataCenterMap()); +
> > QMap<QString, KoDataCenter *> dataCenterMap;
> > +    if (m_document)
> > +        dataCenterMap =3D m_document->dataCenterMap();
> > +    KoShape *shape =3D
> > factory->createDefaultShapeAndInit(dataCenterMap);
> > shape->setPosition(QPointF(0, page.offsetInDocument()));
> >      return shape;
> >  }
>
> In which cases it is possible that you do not have any document? The
> problem with that is that some shapes (text and picture shape) will not
> work when the dataCenterMap is empty.

In the unit tests.
The unit tests started crashing :)

It would be awesome if we could get the failing unit test count to zero so=
=20
people could run them before committing to check for regressions.  :)

http://www.koffice.org/testresults/status.html
All the red stars are regressions.
=2D-=20
Thomas Zander

--nextPart1372783.Fl2OfgSKSo
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkkEE9wACgkQCojCW6H2z/Rp9wCg6g37JDDcdPukgzEpW6a0E5NF
EKwAn3Hr6mJfpiZls8QGYEk8zxwtBZM0
=DiFV
-----END PGP SIGNATURE-----

--nextPart1372783.Fl2OfgSKSo--

--===============0455773098==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============0455773098==--