[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    string changes in KChart possible?
From:       Raphael Langerhorst <raphael-langerhorst () gmx ! at>
Date:       2005-04-30 20:25:40
Message-ID: 200504302225.40667.raphael-langerhorst () gmx ! at
[Download RAW message or body]

Hi all,

I made a change to KChart and found out that it adds a string (just 
_one_):

i18n( "&Configure Data Format..." )

The effect of the patch is to make the data config page - where you 
can flip x/y - available in the Edit menu and the right-click context 
menu. Without the patch this configuration would only be visible when 
the complete config dialog is loaded - "Configure Chart..." (not sure 
everyone does that).

The patch is attached, I want your OK to ask for objections on the 
kde-i18n-doc list.

Regards,
Raphael

PS: I updated the command reference of KChart expecting that this 
option will eventually show up in the menu (well, if not for 1.4, 
then for the next... so no big deal).

["kchart_configdataformat_action.diff" (text/x-diff)]

? pics.gz
Index: kchart.rc
===================================================================
RCS file: /home/kde/koffice/kchart/kchart.rc,v
retrieving revision 1.32
diff -u -p -r1.32 kchart.rc
--- kchart.rc	11 Apr 2005 21:17:33 -0000	1.32
+++ kchart.rc	30 Apr 2005 20:16:53 -0000
@@ -9,6 +9,7 @@
   <Menu name="action_popup"><text>&amp;Chart</text>
    <Action name="config"/>
    <Separator />
+   <Action name="data_format"/>
    <Action name="legend_subtype"/>
    <Action name="headerfooter_subtype"/>
    <Action name="color_config"/>
@@ -41,6 +42,7 @@
 <Menu name="action_popup">
  <Action name="config"/>
  <Separator />
+ <Action name="data_format"/>
  <Action name="legend_subtype"/>
  <Action name="headerfooter_subtype"/>
  <Action name="legend_config"/>
Index: kchartConfigDialog.cc
===================================================================
RCS file: /home/kde/koffice/kchart/kchartConfigDialog.cc,v
retrieving revision 1.69
diff -u -p -r1.69 kchartConfigDialog.cc
--- kchartConfigDialog.cc	6 Apr 2005 22:39:47 -0000	1.69
+++ kchartConfigDialog.cc	30 Apr 2005 20:16:54 -0000
@@ -78,7 +78,11 @@ KChartConfigDialog::KChartConfigDialog( 
     //addTab( _geompage, i18n( "&Geometry" ) );
     setCaption( i18n( "Chart Config Dialog" ) );
 
-    if (flags & KC_SUBTYPE) {
+    if (flags & KC_DATAFORMAT) {
+        m_datapage = new KChartDataConfigPage(m_params, this, dat, aux);
+        addTab( m_datapage, i18n( "&Data" ) );
+    }
+    else if (flags & KC_SUBTYPE) {
         subtypePage();
     }
     else if (flags & KC_HEADERFOOTER) {
Index: kchartConfigDialog.h
===================================================================
RCS file: /home/kde/koffice/kchart/kchartConfigDialog.h,v
retrieving revision 1.36
diff -u -p -r1.36 kchartConfigDialog.h
--- kchartConfigDialog.h	6 Apr 2005 22:39:47 -0000	1.36
+++ kchartConfigDialog.h	30 Apr 2005 20:16:54 -0000
@@ -59,7 +59,7 @@ class KChartConfigDialog : public QTabDi
     Q_OBJECT
 
 public:
-    enum { KC_FONT = 1, KC_COLORS = 2, KC_BACK = 4, KC_LEGEND=8, \
KC_SUBTYPE=16,KC_HEADERFOOTER=32,KC_ALL=256 }; +    enum { KC_FONT = 1, KC_COLORS = \
2, KC_BACK = 4, KC_LEGEND=8, \
KC_SUBTYPE=16,KC_HEADERFOOTER=32,KC_DATAFORMAT=64,KC_ALL=256 };  KChartConfigDialog( \
KChartParams* params,  QWidget* parent, int flags,
 			KoChart::Data *dat, KChartAuxiliary *aux );
Index: kchart_view.cc
===================================================================
RCS file: /home/kde/koffice/kchart/kchart_view.cc,v
retrieving revision 1.113
diff -u -p -r1.113 kchart_view.cc
--- kchart_view.cc	25 Apr 2005 06:48:56 -0000	1.113
+++ kchart_view.cc	30 Apr 2005 20:16:54 -0000
@@ -137,14 +137,20 @@ KChartView::KChartView( KChartPart* part
     m_legendConfig = new KAction( i18n( "&Configure Legend..." ), 0,
                             this, SLOT( slotConfigLegend() ),
                             actionCollection(), "legend_config" );
-    m_subTypeChartConfig= new KAction( i18n( "&Configure Sub Type Chart..." ), 0,
+
+    m_subTypeChartConfig = new KAction( i18n( "&Configure Sub Type Chart..." ), 0,
                             this, SLOT( slotConfigSubTypeChart() ),
                             actionCollection(), "legend_subtype" );
-    m_headerFooterConfig= new KAction( i18n( "&Configure Header Footer..." ), 0,
+
+    m_dataFormatConfig = new KAction( i18n( "&Configure Data Format..." ), 0,
+                            this, SLOT( slotConfigDataFormat() ),
+                            actionCollection(), "data_format" );
+
+    m_headerFooterConfig = new KAction( i18n( "&Configure Header Footer..." ), 0,
                             this, SLOT( slotConfigHeaderFooterChart() ),
                             actionCollection(), "headerfooter_subtype" );
 
-    m_pageLayoutConfig=new KAction( i18n( "Page Layout..." ), 0,
+    m_pageLayoutConfig = new KAction( i18n( "Page Layout..." ), 0,
                             this, SLOT( slotConfigPageLayout() ),
                             actionCollection(), "page_layout" );
 
@@ -541,6 +547,10 @@ void KChartView::slotConfigLegend()
    config(KChartConfigDialog::KC_LEGEND);
 }
 
+void KChartView::slotConfigDataFormat()
+{
+    config(KChartConfigDialog::KC_DATAFORMAT);
+}
 
 void KChartView::slotConfigSubTypeChart()
 {
Index: kchart_view.h
===================================================================
RCS file: /home/kde/koffice/kchart/kchart_view.h,v
retrieving revision 1.37
diff -u -p -r1.37 kchart_view.h
--- kchart_view.h	13 Apr 2005 19:22:57 -0000	1.37
+++ kchart_view.h	30 Apr 2005 20:16:54 -0000
@@ -62,6 +62,7 @@ public slots:
     void  slotConfigLegend();
     void  slotConfigHeaderFooterChart();
     void  slotConfigSubTypeChart();
+    void  slotConfigDataFormat();
 
     void  slotConfigPageLayout();
     void  importData();
@@ -87,6 +88,7 @@ private:
     KAction  *m_fontConfig;
     KAction  *m_backConfig;
     KAction  *m_legendConfig;
+    KAction  *m_dataFormatConfig;
     KAction  *m_subTypeChartConfig;
     KAction  *m_headerFooterConfig;
     KAction  *m_pageLayoutConfig;



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic