[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Re: fixed template for bug #77962
From:       Laurent Montel <montel () kde ! org>
Date:       2004-06-10 20:20:06
Message-ID: 200406102220.08102.montel () kde ! org
[Download RAW message or body]

Le Thursday 10 June 2004 23:43, Raphael Langerhorst a écrit :
> On Wednesday 09 June 2004 11:11, Nicolas Goutte wrote:
> > On Wednesday 09 June 2004 13:05, Raphael Langerhorst wrote:
> > > Hi all,
> > >
> > > attached is the fixed template for bug number 77962.
>
> Now I manually (with KWrite) edited the Invoice.kst template and just
> modified one line with the print range. This is the only change necessary
> to get the template printing out-of-the-box.
>
> > Please in such a case, consider also emailing to the bug report, in this
> > case 77962@bugs.kde.org
> > (The problem is if the bug has to be searched again, then the patch is
> > not with the bug report.)
>
> I'll attach this patch to the bug report in a minute.
>
> > As for your patch, sorry, I do not know KSpread enough.
>
> In the meantime I had a little private email exchange with Laurent. He
> actually told me how to create templates. But I don't want to replace the
> current template anymore. It seems to be enough to just redefine the print
> range.

It's right.

> Can people please check whether this patch is OK?

This patch is ok.

For me we mustn't have a print-range into a template so you can commit.
But it doesn't fix your bug.
Bug is into kspread print range function.

I fixed a part of bug (not perfect again), now we can print page when we 
select an area (print range)

I will backport it to koffice 1.3 branch.

> I now already have a CVS 
> account and if I get a OK from you I'll commit the patch to HEAD.

You can commit if you want.

> Besides: backporting... can anyone backport the patch to 1.3? (I don't have
> a branch around and no bandwith to fetch one).

You can just use this command:
cvs checkout -rKOFFICE_1_3_BRANCH 
koffice/kspread/templates/Business/Invoice.kst

commit your patch.
Not necessary to have complet koffice-1.3 branch on your HD. 

Regards.


> It would also be ok if you 
> commit the patch to HEAD as well, but let me know you already did.
>
> THANKS!!
>
> Raphael
>
>
> PS: if one has a patch for backporting as well this is nothing else than:
> having a 1.3 branch beside the HEAD branch and simply committing the patch
> to both, right?
>
> > (...)
> >
> > Have a nice day!
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@mail.kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]