[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    kpresenter patch for crash
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2004-01-19 11:42:56
Message-ID: 200401191242.56650.t.zachmann () zagge ! de
[Download RAW message or body]

Hello all,

I found a way to crash kpresenter. To reproduce
1) Duplicate slide
2) Scroll down 
3) undo

-> crash

The attached patch solves the problem. Please review. If it is ok I'll also 
backport it to the 1.3 branch.

Thorsten

["patch68" (text/x-diff)]

Index: kpresenter_view.cc
===================================================================
RCS file: /home/kde/koffice/kpresenter/kpresenter_view.cc,v
retrieving revision 1.997
diff -u -3 -p -r1.997 kpresenter_view.cc
--- kpresenter_view.cc	14 Jan 2004 17:02:32 -0000	1.997
+++ kpresenter_view.cc	19 Jan 2004 11:29:13 -0000
@@ -4164,13 +4164,16 @@ void KPresenterView::skipToPage( int num
     if ( num < 0 || num > static_cast<int>( m_pKPresenterDoc->getPageNums() ) - 1 || !m_canvas )
         return;
     m_canvas->exitEditMode();
-    vert->setValue( 0 );
     currPg = num;
     emit currentPageChanged( currPg );
     if( sidebar )
         sidebar->setCurrentPage( currPg );
     KPrPage* page = m_pKPresenterDoc->pageList().at( currPg );
     m_canvas->setActivePage( page );
+    // don't scroll before new active page is set,
+    // the page active until then might have been deleted
+    vert->setValue( 0 );
+    horz->setValue( 0 );
     if ( notebar ) {
         QString text = page->noteText( );
         notebar->setCurrentNoteText( text );


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]