[prev in list] [next in list] [prev in thread] [next in thread]
List: kmail-devel
Subject: Bug#30036: [PATCH] Re: Bug#30036: editing mail in outbox with adress containing underscore causes p
From: Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date: 2001-07-31 11:20:58
[Download RAW message or body]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tuesday 31 July 2001 01:51, Ingo Klöcker wrote:
> On Tuesday, 31. July 2001 01:17, Sascha Raabe wrote:
<snip>
> > ok, sorry, little incorrectness in my descrpition: the adress has
> > to contain two email adresses and the second one has to contain an
> > german "umlaut" (e.g. ä, ü, ö, etc.)
> >
> > step-by-step instruction i did here:
> >
> > 1. compose a new message with following adress field:
> > "foo bar" <foo bar@localhost>,"törg" <toerg@localhost>
<snip>
This will not exhibit the problem. But
Foo_Bär <foobaer@foo.org>
will!
> I still can't reproduce it. It seems to have been fixed already.
NAK.
> Therefore I close this bug report.
ACK, because this patch fixes the problem.
KMMsgBase::encodeRFC2047Quoted() "forgot" to encode underscores, which
are a shortcut encoding for =20 (space) (in QP, in RFC2047 only? - too
lazy to look up). On decode that underscore was decoded to a space ->
bingo.
Index: kmmsgbase.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmmsgbase.cpp,v
retrieving revision 1.83
diff -u -3 -p -r1.83 kmmsgbase.cpp
- --- kmmsgbase.cpp 2001/07/29 07:54:52 1.83
+++ kmmsgbase.cpp 2001/07/31 11:08:53
@@ -328,7 +328,7 @@ QCString KMMsgBase::encodeRFC2047Quoted(
for (unsigned int i = 0; i < aStr.length(); i++)
{
ch = aStr.at(i);
- - if (ch >= 128 || especials.find(aStr.at(i)) != -1)
+ if (ch >= 128 || ch == '_' || especials.find(aStr.at(i)) != -1)
{
result += "=";
hex = ((ch & 0xF0) >> 4) + 48;
Marc
- --
Marc Mutz <Marc@Mutz.com>
http://marc.mutz.com/
http://www.mathematik.uni-bielefeld.de/~mmutz/
http://EncryptionHOWTO.sourceforge.net/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE7Zq5l3oWD+L2/6DgRAmcvAJ42aTuiXv/TKHz3lHg6HCpN2/WhiQCeLX1n
qo1GOI4Z2nBEjvMfLECcqIw=
=KrU0
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic