[prev in list] [next in list] [prev in thread] [next in thread]
List: kmail-devel
Subject: [PATCH] Initialise font buttons when kmail composer is displayed
From: David Jarvie <lists () astrojar ! org ! uk>
Date: 2006-04-29 10:18:56
Message-ID: 200604291118.57088.lists () astrojar ! org ! uk
[Download RAW message or body]
Currently, when the compose window is activated in KMail (3.5 branch), and
HTML mode is set, the font buttons are not initialised to show which font is
active. The patch below rectifies this. OK to apply?
The story behind this patch may be of interest:
Finally after years of gentle persuasion, my wife (who is not computer
literate and finds learning new things on computers an unwanted chore and
hugely frustrating) agreed to try Linux. Her normally unreliable Windows 98
system was now giving severe trouble. The major stumbling block to using
Linux boiled down to getting an email program as similar as possible to
Outlook Express. (All the other programs which she uses are available on
Linux.) She took one look at Thunderbird (where I couldn't work out how to
configure the fonts, despite trying suggestions on the web) and found it too
ugly to use. So I tried kmail (which she had rejected a couple of years ago),
and she somewhat reluctantly agreed to try it - until we found the bug which
this patch fixes. If I hadn't fixed it quickly, she would again have refused
to continue. I don't know how many others might be like her, but sometimes
the little things really matter...
And another footnote - it made me realise how wonderful KDE's easy
configurability is - I could tweak kmail in lots of ways until it nearly
matched what she wanted. Compare that to Thunderbird, where the configuration
options seem to be much more limited, and many of the options are settable
via an obscure method which requires hours of research to work out.
--
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/linux/kalarm.html
Index: kmcomposewin.cpp
===================================================================
--- kmcomposewin.cpp (revision 534728)
+++ kmcomposewin.cpp (working copy)
@@ -399,6 +399,7 @@
mMsg = 0;
if (aMsg)
setMsg(aMsg);
+ fontChanged( mEditor->currentFont() ); // set toolbar buttons to correct
values
mDone = true;
}
@@ -4050,9 +4051,7 @@
mHtmlMarkup = true;
toolBar("htmlToolBar")->show();
// markup will be toggled as soon as markup is actually used
- fontChanged( mEditor->currentFont().family() ); // set buttons in correct
position
- fontAction->setFont( mEditor->currentFont().family() );
- fontSizeAction->setFontSize( mEditor->currentFont().pointSize() );
+ fontChanged( mEditor->currentFont() ); // set buttons in correct position
mSaveFont = mEditor->currentFont();
}
else
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic