[prev in list] [next in list] [prev in thread] [next in thread]
List: kmail-devel
Subject: Re: Patch for BUG:88367
From: Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date: 2005-02-28 23:20:16
Message-ID: 200503010020.27093 () erwin ! ingo-kloecker ! de
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Monday 28 February 2005 07:11, Matt Douhan wrote:
> On Sun February 27 2005 22:49, Ingo Klöcker wrote:
> > On Sunday 27 February 2005 21:20, Matt Douhan wrote:
> > > + if ( !changedIdents.isEmpty() ) {
> > > + QString changedIdentsString = changedIdents.join( ", " );
> > > + QString information;
> > > + int commaCount = changedIdentsString.contains( ',' );
> >
> > Use changedIdents.count() instead of counting commas.
>
> Fixed in this new patch, and much neater with this solution, no need
> to convert stuff back and forwards.
>
> > typo: "This identity _has_ been changed ..."
>
> Fixed
>
> > > + QString infoMsg( "<qt><p><b>" + changedIdentsString +
> > > + "</b></p><p>" + information +
> > > + "</p></qt>" );
> > > + KMessageBox::information( this, infoMsg,
> > > i18n("Identitychanges") ); + }
> >
> > I propose to use
> > KMessageBox::informationList( this, information, changedIdents );
>
> Aha, a msgbox that takes a stringlist directly, way neater, fixed
> also in this patch.
Now the patch looks almost perfect. Only one small thing: I would add a
colon to the end of the information strings so that they read "...
transport:".
Please commit the patch to HEAD.
Regards,
Ingo
[Attachment #5 (application/pgp-signature)]
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic