[prev in list] [next in list] [prev in thread] [next in thread]
List: kmail-devel
Subject: Re: [PATCH] make kio_imap use peek and kmail set imap read status
From: Till Adam <adam () kde ! org>
Date: 2003-12-30 19:52:12
Message-ID: 200312302052.21912.adam () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Tuesday 30 December 2003 18:25, Ingo Klöcker wrote:
> On Tuesday 30 December 2003 14:18, Till Adam wrote:
> > - if (message()->isNew() || message()->isUnread() ||
> > message()->isRead()) - message()->setStatus(KMMsgStatusRead);
> > + SerNumList serNums;
> > + if (message()->isNew() || message()->isUnread()) {
> > + serNums.append( message()->getMsgSerNum() );
> > + }
> > +
> > + KMCommand *command = new KMSetStatusCommand( KMMsgStatusRead,
> > serNums ); + command->start();
>
> I guess it doesn't make much sense to call the KMSetStatusCommand with
> an empty list of serial numbers. So the command should be moved into the
> if-branch.
Ok. Changed.
> > if ( message()->isNew() || message()->isUnread() ) {
> > KMMessage * receipt = message()->createMDN( MDN::ManualAction,
> > - MDN::Displayed,
> > - true /* allow GUI */ );
> > + MDN::Displayed, true /* allow GUI */ );
>
> This indentation doesn't look right.
Ok. Changed.
> About the change in kio_imap. It would be nicer if it would be possible
> to use BODY and BODY.PEEK (depending on the situation). Isn't it
> possible to extend the IMAP slave accordingly? Then no apps that rely on
> the current behavior would break.
Hm. I kind of think it is really a bugfix, as the old behavior was arguably
more of a nasty side effect than intended behavior. Maybe you are right,
though. Carsten, any idea on how you want that done? Do you agree with Ingo?
Till
[Attachment #5 (application/pgp-signature)]
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic