[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    New Window under https...
From:       Keunwoo Lee <klee () cs ! washington ! edu>
Date:       2000-11-17 10:44:21
[Download RAW message or body]

A tiny patch.  Makes the 'Location -> New Window' action use the
"webbrowsing" view profile when current protocol is https.

Possible long-term solution: add a QMap from protocols to view profile
names?  And then maybe expose this to the user in a kcontrol tab?  Would
be confusing to novice users, though we could hide it in an "Advanced ..."
dialog box...  Well, there's probably a better way to do it.  Not
something I have time to implement or think about right now however.

~k.lee


["klee-20001117.diff" (TEXT/PLAIN)]

*** konq_mainwindow.cc	Wed Nov 15 05:39:04 2000
--- konq_mainwindow.cc.new	Fri Nov 17 02:10:55 2000
***************
*** 773,779 ****
  void KonqMainWindow::slotNewWindow()
  {
    // ### Maybe use profile from current window, if set ?
!   if ( m_currentView && m_currentView->url().protocol() == QString::fromLatin1( "http" ) )
      KonqMisc::createBrowserWindowFromProfile(
        locate( "data", QString::fromLatin1("konqueror/profiles/webbrowsing") ),
        QString::fromLatin1("webbrowsing") );
--- 773,781 ----
  void KonqMainWindow::slotNewWindow()
  {
    // ### Maybe use profile from current window, if set ?
!   QString current_protocol = m_currentView->url().protocol();
!   if ( m_currentView && (current_protocol == QString::fromLatin1( "http" )
!                          || current_protocol == QString::fromLatin1( "https" )) )
      KonqMisc::createBrowserWindowFromProfile(
        locate( "data", QString::fromLatin1("konqueror/profiles/webbrowsing") ),
        QString::fromLatin1("webbrowsing") );


[prev in list] [next in list] [prev in thread] [next in thread]