--===============6454978180503518691== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127930/#review95554 ----------------------------------------------------------- Ship it! Thank you! - Olivier Goffart On May 17, 2016, 2:47 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127930/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 2:47 p.m.) > > > Review request for Dolphin, Emmanuel Pescosta, Michael Pyne, and Olivier Goffart. > > > Bugs: 357479 > https://bugs.kde.org/show_bug.cgi?id=357479 > > > Repository: dolphin > > > Description > ------- > > KPluginLoader::instantiatePlugins() wraps QPluginLoader::instance(), > which doesn't return a new object for each call, so if we set the > KFileItemModelRolesUpdater instance as parent to the plugin the shared > instance will be deleted leading to crashes when other instances of > KFileItemModelRolesUpdater tries to use their plugin objects. > > To fix this, set the QApplication as a parent. > > BUG: 357479 > > > Diffs > ----- > > src/kitemviews/kfileitemmodelrolesupdater.cpp e5353dc > > Diff: https://git.reviewboard.kde.org/r/127930/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============6454978180503518691== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127930/ |
Ship it!
Thank you!
- Olivier Goffart
On May 17th, 2016, 2:47 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:
Review request for Dolphin, Emmanuel Pescosta, Michael Pyne, and Olivier Goffart.
By Martin Tobias Holmedahl Sandsmark.
Updated May 17, 2016, 2:47 p.m.
Bugs:
357479
Repository:
dolphin
Description
Testing
Diffs
|