[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 113101: Fix Bug 287983 - Dolphin truncates tooltip information for long file name
From: Luciano Montanaro <mikelima () gmail ! com>
Date: 2013-10-10 13:59:39
Message-ID: CALY5qtbKuj929218Vg0jKLfm-73P6XCcWFOXHvFpD9RKauNspg () mail ! gmail ! com
[Download RAW message or body]
I wish size calculations were done in font-relative units... using
QFontMetrics on the tooltip font. Then you could pick a reasonable size
that accounts for user preferences and pixel density.
On Thu, Oct 10, 2013 at 3:09 PM, Kai Uwe Broulik <kde@privat.broulik.de>wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113101/
>
> Can you test it doesn't break with huge font sizes? A fixed 250px maximum width \
> looks dangerous to me.
>
> - Kai Uwe
>
> On October 4th, 2013, 5:53 p.m. UTC, Emmanuel Pescosta wrote:
> Review request for Dolphin.
> By Emmanuel Pescosta.
> *Bugs: * 287983 <http://bugs.kde.org/show_bug.cgi?id=287983>
> *Repository: * kde-baseapps
> Description
>
> Use KStringHandler and QTextLayout to wrap the text (file name)
> into the maximum width of the label "name".
>
> Testing
>
> Works
>
> Diffs
>
> - dolphin/src/views/tooltips/filemetadatatooltip.cpp (c22f6be)
>
> View Diff <http://git.reviewboard.kde.org/r/113101/diff/>
> File Attachments
>
> - Tooltip Widget with a long file name - Dolphin \
> 4.11.2<http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png>
>
> - Tooltip Widget with a long file name - Dolphin 4.11.3 \
> (Patched)<http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png>
>
>
--
Luciano Montanaro
Anyone who is capable of getting themselves made President should on no
account be allowed to do the job. -- Douglas Adams
[Attachment #3 (text/html)]
<div dir="ltr">I wish size calculations were done in font-relative units... using \
QFontMetrics on the tooltip font. Then you could pick a reasonable size that accounts \
for user preferences and pixel density.</div><div class="gmail_extra"> <br><br><div \
class="gmail_quote">On Thu, Oct 10, 2013 at 3:09 PM, Kai Uwe Broulik <span \
dir="ltr"><<a href="mailto:kde@privat.broulik.de" \
target="_blank">kde@privat.broulik.de</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113101/" \
target="_blank">http://git.reviewboard.kde.org/r/113101/</a> </td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Can \
you test it doesn't break with huge font sizes? A fixed 250px maximum width looks \
dangerous to me.</pre> <span class="HOEnZb"><font color="#888888">
<br>
<p>- Kai Uwe</p></font></span><div class="im">
<br>
<p>On October 4th, 2013, 5:53 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url('');background-repeat:repeat-x;border:1px black \
solid"> <tbody><tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287983" target="_blank">287983</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kde-baseapps
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Use \
KStringHandler and QTextLayout to wrap the text (file name) into the maximum width of \
the label "name".</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Works</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>dolphin/src/views/tooltips/filemetadatatooltip.cpp <span \
style="color:grey">(c22f6be)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113101/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png" \
target="_blank">Tooltip Widget with a long file name - Dolphin 4.11.2</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png" \
target="_blank">Tooltip Widget with a long file name - Dolphin 4.11.3 \
(Patched)</a></li>
</ul>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Luciano \
Montanaro<br><br>Anyone who is capable of getting themselves made President should on \
no account be allowed to do the job. -- Douglas Adams<br> <br> </div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic